Fix class-level retry with Gradle 5.0 and Suite engine or @Nested test classes #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Clausen <dclausen@gradle.com>
When using Gradle 5.0 in combination with JUnit's suite runner or when using @nested test classes, we lack test events for the intermediate classes. This leads to a problem when an intermediate class is configured for class-level retry. In order to fix this, we manually remove specific entries from the failed tests at the end of a round. But we only do this for Gradle 5.0, as test reporting for newer version does not exhibit this problem. Signed-off-by: Daniel Clausen <dclausen@gradle.com>
…sses Verification for Gradle 5.0 adjusted. Signed-off-by: Daniel Clausen <dclausen@gradle.com>
pshevche
requested changes
Nov 2, 2023
plugin/src/main/java/org/gradle/testretry/internal/executer/RetryTestResultProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Clausen <dclausen@gradle.com>
pshevche
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds special handling when Gradle 5.0 is used.
At the end of each round, entries for test classes w/o test methods from
previousRoundFailedTests, when using Gradle 5.0. For Gradle 5.1 and above this would automatically happen, as Gradle also reports events for intermediate classes, when JUnit's suite engine is used or when test classes are@nested.To be on the safe side, we're only removing entries for test classes, if we observed this test class during the current round. It's not a perfect solution but allows using the class-retry feature of the Test Retry Gradle plugin together with test suites and nested class for Gradle 5.0 as well.
Fixes #230