Fix a condition that ignore maxFailures parameter for Spock Stepwise specifications #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyAkentyev
force-pushed
the
fix/234
branch
3 times, most recently
from
07342ef to
93b5c72
Compare
|
Hi @marcphilipp, could you advise who could review PR and suggest next steps? p.s. unfortunately there is no contribution guide |
|
@AlexeyAkentyev Thank you for your PR! We'll review it in the next few days. |
leonard84
approved these changes
Nov 23, 2023
snoopcheri
approved these changes
Nov 23, 2023
…specifications (gradle#234) Signed-off-by: AlexeyAkentyev <65549207+AlexeyAkentyev@users.noreply.github.com>
Signed-off-by: Leonard Brünings <leonard.bruenings@gradle.com>
|
Thanks for your contribution @AlexeyAkentyev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue when Spock Stepwise specifications are ignored by maxFailures parameter.
Detailed description (#234)