Support JUnit TestNG engine #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshevche
commented
Jul 11, 2024
| .filter(test -> testFrameworkStrategy.isExpectedUnretriedTest(entry.getKey(), test)) | ||
| .collect(Collectors.toSet()) | ||
| )); | ||
| expectedUnretriedTests.forEach((className, tests) -> previousRoundFailedTests.remove(className, tests::contains)); |
There was a problem hiding this comment.
💬 Ideally, we would also report failed descriptors as successful, but at this point, we have no clue where in the hierarchy they belong or how to construct a valid descriptor.
With all of the issues with the TestNG reporting, it seems like putting lipstick on a pig. So, I suggest not to bother and just make sure that retries work correctly.
pshevche
force-pushed
the
pshevche/support-testng-engine
branch
2 times, most recently
from
8c6e2aa to
0e804e3
Compare
pshevche
force-pushed
the
pshevche/support-testng-engine
branch
from
0e804e3 to
5f18200
Compare
Signed-off-by: Pavlo Shevchenko <pshevchenko@gradle.com>
Signed-off-by: Pavlo Shevchenko <pshevchenko@gradle.com>
Signed-off-by: Pavlo Shevchenko <pshevchenko@gradle.com>
Signed-off-by: Pavlo Shevchenko <pshevchenko@gradle.com>
Signed-off-by: Pavlo Shevchenko <pshevchenko@gradle.com>
Signed-off-by: Pavlo Shevchenko <pshevchenko@gradle.com>
pshevche
force-pushed
the
pshevche/support-testng-engine
branch
from
5f18200 to
f2ce44e
Compare
jean-andre-gauthier
approved these changes
Jul 15, 2024
| @@ -205,7 +244,7 @@ class TestNGFuncTest extends AbstractFrameworkFuncTest { | |||
|
|
|||
| public class OrderedTests { | |||
| @Test(dependsOnMethods = {"childTest"}) | |||
| public void grandchildTest() {} | |||
| public void grandChildTest() {} | |||
There was a problem hiding this comment.
Afaik grandchild is a single word, so the case could be made to leave the casing as-is
There was a problem hiding this comment.
Agree, it is hard to make assertions, though, because childTest matches both the childTest and the grandchildTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SAP reports a number of issues when TestNG run with JUnit TestNG Engine are retried:
This PR addresses the first two and I manually verified that the fix also resolves Build Scan publication errors. The plan forward is to release a Develocity plugin RC with this fix and validate with the customer if all of the issues are resolved.