Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exportAllPackages() breaks module for multi-release jar packages #77

Closed
crschnick opened this issue Nov 4, 2023 · 1 comment · Fixed by #83
Closed

exportAllPackages() breaks module for multi-release jar packages #77

crschnick opened this issue Nov 4, 2023 · 1 comment · Fixed by #83
Labels
a:bug Something isn't working

Comments

@crschnick
Copy link

I am using extra-java-module-info v1.5 to modularize the dependency org.kohsuke:github-api:1.317. When using exportAllPackages() it somehow breaks with an invalid module exception caused by a multi-release package being exported. So for now I export all packages manually and that works for me like this
@jjohannes
Copy link
Member

Thanks for reporting.

@jjohannes jjohannes added the a:bug Something isn't working label Nov 4, 2023
jjohannes added a commit that referenced this issue Nov 17, 2023
@jjohannes
Take 'META-INF/versions' into account when calculating package names
79591c8 
Fixes #77
@jjohannes jjohannes mentioned this issue Nov 17, 2023
Merged
jjohannes added a commit that referenced this issue Nov 17, 2023
@jjohannes
Take 'META-INF/versions' into account when calculating package names (#…
2f90e74 
…83)

Fixes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@jjohannes @crschnick