Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'requireAllDefinedDependencies' does not work reliably for 'annotationProcessor' #81

Closed
jjohannes opened this issue Nov 17, 2023 · 1 comment · Fixed by #82
Closed
Labels
a:bug Something isn't working

Comments

@jjohannes
Copy link
Member

Because the annotationProcessor path is not passed into the transform requireAllDefinedDependencies fails for modules that are only on the annotationProcessor path and not on the runtime or compile classpath.

@jjohannes jjohannes added the a:bug Something isn't working label Nov 17, 2023
@jjohannes
Copy link
Member Author

jjohannes commented Nov 17, 2023

Looking at this, I also realized that the current decision of whether something is requires or requires transitive is flawed.
For that to work reliably, we would need the 'compile classpath' of the module we are looking at right now.
The 'compileDependencies' set in ExtraJavaModuleInfoTransform however is based only on the 'compile classpath' of the final consumer.

I'll change this behavior to always do requires transitive for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant