Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursively exclude tests folder and its contents #141

Merged
merged 2 commits into from
Dec 23, 2021
Merged

recursively exclude tests folder and its contents #141

merged 2 commits into from
Dec 23, 2021

Conversation

sugatoray
Copy link
Contributor

This will partially address #140. Once this is merged a new version of the package needs to be published on PyPI before closing #140.

Changes

Fixes # (issue)

Type of change

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas NA
  • I have made corresponding changes to the documentation NA
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change? @aniketmaurya Should this go in to the changelog?

@aniketmaurya aniketmaurya enabled auto-merge (squash) December 17, 2021 09:49
aniketmaurya
aniketmaurya approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@aniketmaurya aniketmaurya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sugatoray
Copy link
Contributor Author

@aniketmaurya Could you please see if you could merge it? Thank you.

@aniketmaurya aniketmaurya merged commit 5d349e9 into gradsflow:main Dec 23, 2021
@aniketmaurya
Copy link
Contributor

Thanks for the PR Sugato, I have merged the changes 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketmaurya aniketmaurya aniketmaurya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sugatoray @aniketmaurya