Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model.save test #147

Merged
merged 5 commits into from
Dec 29, 2021
Merged

add model.save test #147

merged 5 commits into from
Dec 29, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Dec 29, 2021

Changes

Fixes # (issue)

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@github-actions github-actions bot added the test label Dec 29, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya enabled auto-merge (squash) December 29, 2021 20:15
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #147 (57cf004) into main (ed9e5c5) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   96.62%   96.67%   +0.05%     
==========================================
  Files          65       66       +1     
  Lines        1867     1896      +29     
==========================================
+ Hits         1804     1833      +29     
  Misses         63       63              
Flag Coverage Δ
unittests 96.67% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gradsflow/callbacks/raytune.py 100.00% <100.00%> (ø)
gradsflow/models/base.py 88.69% <100.00%> (+1.53%) ⬆️
tests/conftest.py 100.00% <100.00%> (ø)
tests/models/test_model.py 98.46% <100.00%> (+0.38%) ⬆️
gradsflow/core/base.py 96.77% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9e5c5...57cf004. Read the comment docs.

@aniketmaurya aniketmaurya merged commit ef5b1ed into main Dec 29, 2021
@aniketmaurya aniketmaurya deleted the test/save_model branch December 29, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant