Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anti pattern fixes from deepsource #176

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

skp-github
Copy link
Contributor

Changes

Changes based on Deepsource anti-pattern

Inorder to keep the code standards the anti pattern issues need to be fixed or ignored accordingly

Fixes # (issue)

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG (docs/CHANGELOG.md) in case of a major change?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @skp-github! Thank you for opening your first pull request in this repo. We are so happy that you have decided to contribute and value your contribution. Please read these materials before proceeding: Contributing Guide and Code of Conduct.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #176 (be6fc0d) into main (f0d4564) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          69       69           
  Lines        2117     2117           
=======================================
  Hits         2011     2011           
  Misses        106      106           
Flag Coverage Δ
unittests 94.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gradsflow/callbacks/wandb.py 94.82% <ø> (ø)
gradsflow/models/base.py 87.62% <ø> (ø)
gradsflow/tuner/tuner.py 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d4564...be6fc0d. Read the comment docs.

Copy link
Contributor

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@aniketmaurya aniketmaurya merged commit 85c658f into gradsflow:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants