Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix best checkpoints model loading #52

Merged
merged 10 commits into from
Sep 2, 2021
Merged

fix best checkpoints model loading #52

merged 10 commits into from
Sep 2, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Sep 2, 2021

Changes

Fixes #48

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@github-actions github-actions bot added the test label Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #52 (8c7dd46) into main (28bdb12) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   98.41%   98.57%   +0.15%     
==========================================
  Files          15       17       +2     
  Lines         253      280      +27     
==========================================
+ Hits          249      276      +27     
  Misses          4        4              
Flag Coverage Δ
unittests 98.57% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gradsflow/__init__.py 100.00% <100.00%> (ø)
gradsflow/core/automodel.py 98.48% <100.00%> (+0.07%) ⬆️
gradsflow/core/base.py 100.00% <100.00%> (ø)
gradsflow/core/callbacks.py 100.00% <100.00%> (ø)
tests/core/test_automodel.py 100.00% <100.00%> (ø)
tests/tasks/test_image.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1636bbb...8c7dd46. Read the comment docs.

@aniketmaurya aniketmaurya self-assigned this Sep 2, 2021
@aniketmaurya aniketmaurya added this to the 0.0.4 milestone Sep 2, 2021
@aniketmaurya aniketmaurya added bug / fix Something isn't working or a Bug Fix and removed bug / fix Something isn't working or a Bug Fix labels Sep 2, 2021
@aniketmaurya aniketmaurya enabled auto-merge (squash) September 2, 2021 15:02
@aniketmaurya aniketmaurya changed the title fix best checkpoints fix best checkpoints model loading Sep 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya merged commit e61763d into main Sep 2, 2021
@aniketmaurya aniketmaurya deleted the 48_checkpoint branch September 27, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model is not loaded from best checkpoint after HPO
1 participant