Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom User-Agent header for Loki #188

Closed
rfratto opened this issue Sep 8, 2020 · 1 comment · Fixed by #270
Closed

Custom User-Agent header for Loki #188

rfratto opened this issue Sep 8, 2020 · 1 comment · Fixed by #270
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness

Comments

@rfratto
Copy link
Member

rfratto commented Sep 8, 2020

Similar to #166, it would be useful to track log writers through a custom User-Agent header. An upstream PR has been opened to support this.

Once a new release of Promtail is available with grafana/loki#2603 merged, the Agent can update its vendor and revert the hacky workaround that was necessary prior to having the Loki change merged.
@stale
Copy link

stale bot commented Oct 9, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue/PR mark as stale due lack of activity label Oct 9, 2020
@rfratto rfratto added the keepalive Never close from staleness label Oct 9, 2020
@stale stale bot closed this as completed Oct 16, 2020
@rfratto rfratto reopened this Oct 16, 2020
@rfratto rfratto removed the stale Issue/PR mark as stale due lack of activity label Oct 16, 2020
rfratto referenced this issue in rfratto/agent Dec 2, 2020
@rfratto
override Loki User-Agent header
ac68084 
Fixes #188
@rfratto rfratto mentioned this issue Dec 2, 2020
Merged
3 tasks
rfratto referenced this issue in rfratto/agent Dec 7, 2020
@rfratto
override Loki User-Agent header
9032d91 
Fixes #188
rfratto added a commit that referenced this issue Dec 7, 2020
@rfratto
Override Promtail User-Agent header (#270)
68e13a5 
* override Loki User-Agent header

Fixes #188

* update CHANGELOG

* revert hacky workaround, no longer needed now that fix in loki is merged

* use prometheus version for setting user-agent header

This avoids the same problem that Loki originally had and allows
downstream importers that use prometheus/common/version to import
the loki package without it overwriting their build info.
mattdurham pushed a commit that referenced this issue Nov 11, 2021
@rfratto
Override Promtail User-Agent header (#270)
98d0577 
* override Loki User-Agent header

Fixes #188

* update CHANGELOG

* revert hacky workaround, no longer needed now that fix in loki is merged

* use prometheus version for setting user-agent header

This avoids the same problem that Loki originally had and allows
downstream importers that use prometheus/common/version to import
the loki package without it overwriting their build info.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Override Promtail User-Agent header rfratto/agent
1 participant
@rfratto