Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly add command to Agent manifests #283

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Dec 10, 2020

PR Description

Some pod controllers on Kubernetes may require an explicit command set if args is also set. See #279 for an example of this, which seems to be Azure-based.

Which issue(s) this PR fixes

Closes #279

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@rfratto rfratto requested a review from hoenn December 10, 2020 17:41
@rfratto rfratto merged commit 6dc5cf4 into grafana:master Dec 10, 2020
@rfratto rfratto deleted the manifest-fix branch December 10, 2020 17:49
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grafana-agent-xxx 0/1 ProviderFailed 0 6m51s
2 participants