update process exporter to v0.7.5 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
reviewed
Jan 6, 2021
| @@ -452,7 +452,7 @@ github.com/modern-go/reflect2 | |||
| github.com/mwitkow/go-conntrack | |||
| # github.com/ncabatoff/go-seq v0.0.0-20180805175032-b08ef85ed833 | |||
| github.com/ncabatoff/go-seq/seq | |||
| # github.com/ncabatoff/process-exporter v0.0.0-00010101000000-000000000000 => github.com/grafana/process-exporter v0.7.3-0.20200902205007-6343dc1182cf | |||
| # github.com/ncabatoff/process-exporter v0.7.5 => github.com/grafana/process-exporter v0.7.3-0.20210106202358-831154072e2a | |||
There was a problem hiding this comment.
Unfamiliar with this process, should we version our fork to 7.5?
There was a problem hiding this comment.
We haven't been adding new tags on our forks to date, which has the unfortunate effect of the Go modules always showing that we're one patch version above the latest upstream tag at the time of forking.
But this is actually based off of the v0.7.5 code if you compare the trees
rfratto
force-pushed
the
process-exporter-0.7.5
branch
from
a1a0178
to
ca6256c
Compare
mattdurham
approved these changes
Jan 7, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* update process exporter to v0.7.5 * update depcheck entry and CHANGELOG
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Updates process-exporter to v0.7.5 based on our downstream fork.
#308 accidentally put the CHANGELOG entry in the v0.9.1 release; I've also taken the opportunity to move it to the proper place here.
Which issue(s) this PR fixes
Closes #265.
Notes to the Reviewer
A merge of our changes upstream is pending. A follow-up PR to remove the replace directive will be opened once that has been merged.
PR Checklist