Configuration file validation subcommand for agentctl #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
config-check
branch
from
c0037ab
to
ad3c9a3
Compare
|
Thanks for working on this! I won't have time to review this until tomorrow, but I'll look at it as soon as I can |
Perform basic YAML and type checking for an Agent configuration file and exit with `1` if there are any errors loading, parsing, or validating the file. Fixes #329
56quarters
force-pushed
the
config-check
branch
from
ad3c9a3
to
65c95f1
Compare
rfratto
reviewed
Jan 19, 2021
cmd/agentctl/main.go
Outdated
| cfg := config.Config{} | ||
| err := config.LoadFile(file, expandEnv, &cfg) | ||
| if err != nil { | ||
| level.Error(logger).Log("msg", "failed to validate config", "err", err) |
There was a problem hiding this comment.
I think it'll be easier to read this if we just print normally:
fmt.Fprintf(os.Stderr, "failed to validate config: %s", err)
rfratto
approved these changes
Jan 20, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Configuration file validation subcommand for agentctl Perform basic YAML and type checking for an Agent configuration file and exit with `1` if there are any errors loading, parsing, or validating the file. Fixes #329 * CR feedback
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform basic YAML and type checking for an Agent configuration file
and exit with
1if there are any errors loading, parsing, or validatingthe file.
Fixes #329
PR Checklist