Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoenn/agentctl register integrations #342

Merged
merged 5 commits into from
Jan 20, 2021

Conversation

hoenn
Copy link
Contributor

@hoenn hoenn commented Jan 20, 2021

PR Description

Registers integrations in agent-ctl. This allows agentctl config-check to function correctly when integrations are present.

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@hoenn hoenn requested a review from rfratto January 20, 2021 18:12
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

importing integrations requires CGO_ENABLED=1 on macOS. Making this
change also requires installing libsystemd-dev in the agentctl Docker
containers, as CGO_ENABLED=1 will cause promtail to include the systemd
tailer.
@rfratto rfratto merged commit b11eba9 into grafana:master Jan 20, 2021
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* Register integrations in agentctl

* Update changelog

* Changelog typo

* Update CHANGELOG.md

* build agentctl with CGO_ENABLED=1

importing integrations requires CGO_ENABLED=1 on macOS. Making this
change also requires installing libsystemd-dev in the agentctl Docker
containers, as CGO_ENABLED=1 will cause promtail to include the systemd
tailer.

Co-authored-by: Robert Fratto <robertfratto@gmail.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants