Elasticsearch exporter integration #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not sure how we test exporters 🤔 |
Refactor the CollectorIntegartion to support multiple collectors and an optional runner function (not used in this commit). This changes will be used in the oncoming ElasticSearch integration.
Vendored github.com/justwatchcom/elasticsearch_exporter This will be used in conjunction with grafana/jsonnet-libs#427
colega
force-pushed
the
elasticsearch-exporter-integration
branch
from
a709890
to
34913c4
Compare
rfratto
reviewed
Jan 21, 2021
There was a problem hiding this comment.
Nice, thanks for working on this! I like the changes to the generic CollectorIntegration.
Just a few small pieces of feedback, but this should be good to go soon!
Can you add this to the testing environment? Look at the example integrations config that enables every integration and the docker compose environment that runs the SUOs
pkg/integrations/elasticsearch_exporter/elasticsearch_exporter.go
Outdated
Show resolved
Hide resolved
pkg/integrations/elasticsearch_exporter/elasticsearch_exporter.go
Outdated
Show resolved
Hide resolved
And make consistent usage of underscores in the yaml keys.
Move the init(), use pointer receivers.
Also renamed elasticsearch `uri` config key to `address`.
rfratto
approved these changes
Jan 22, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Make CollectorIntegration more flexible Refactor the CollectorIntegartion to support multiple collectors and an optional runner function (not used in this commit). This changes will be used in the oncoming ElasticSearch integration. * ElasticSearch exporter integration Vendored github.com/justwatchcom/elasticsearch_exporter This will be used in conjunction with grafana/jsonnet-libs#427 * Remove `es.` prefixes from ElasicSearch configs And make consistent usage of underscores in the yaml keys. * Fix the docs, add elasticsearch_exporter reference * Remove unneeded `_ =` in elasticsearch_exporter * Credits to @colega for elasticsearch_exporter * Consistent ES exporter config with other exporters Move the init(), use pointer receivers. * Add elasticsearch_expoter example Also renamed elasticsearch `uri` config key to `address`. * Add elasticsearch_exporter to depcheck.yml * only reference elasticsearch_exporter once in depcheck file Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Embeds the elasticsearch exporter
Which issue(s) this PR fixes
Uh. Oh! There's no issue for this.
Notes to the Reviewer
First commit is a refactor that I'd recommend to review separately.
PR Checklist