-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch exporter integration #347
Conversation
I'm not sure how we test exporters 🤔 |
Refactor the CollectorIntegartion to support multiple collectors and an optional runner function (not used in this commit). This changes will be used in the oncoming ElasticSearch integration.
Vendored github.com/justwatchcom/elasticsearch_exporter This will be used in conjunction with grafana/jsonnet-libs#427
a709890
to
34913c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for working on this! I like the changes to the generic CollectorIntegration
.
Just a few small pieces of feedback, but this should be good to go soon!
Can you add this to the testing environment? Look at the example integrations config that enables every integration and the docker compose environment that runs the SUOs
pkg/integrations/elasticsearch_exporter/elasticsearch_exporter.go
Outdated
Show resolved
Hide resolved
pkg/integrations/elasticsearch_exporter/elasticsearch_exporter.go
Outdated
Show resolved
Hide resolved
And make consistent usage of underscores in the yaml keys.
Move the init(), use pointer receivers.
Also renamed elasticsearch `uri` config key to `address`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all your work!
* Make CollectorIntegration more flexible Refactor the CollectorIntegartion to support multiple collectors and an optional runner function (not used in this commit). This changes will be used in the oncoming ElasticSearch integration. * ElasticSearch exporter integration Vendored github.com/justwatchcom/elasticsearch_exporter This will be used in conjunction with grafana/jsonnet-libs#427 * Remove `es.` prefixes from ElasicSearch configs And make consistent usage of underscores in the yaml keys. * Fix the docs, add elasticsearch_exporter reference * Remove unneeded `_ =` in elasticsearch_exporter * Credits to @colega for elasticsearch_exporter * Consistent ES exporter config with other exporters Move the init(), use pointer receivers. * Add elasticsearch_expoter example Also renamed elasticsearch `uri` config key to `address`. * Add elasticsearch_exporter to depcheck.yml * only reference elasticsearch_exporter once in depcheck file Co-authored-by: Robert Fratto <robertfratto@gmail.com>
PR Description
Embeds the elasticsearch exporter
Which issue(s) this PR fixes
Uh. Oh! There's no issue for this.
Notes to the Reviewer
First commit is a refactor that I'd recommend to review separately.
PR Checklist