-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/loki: support multiple instances of promtail (BREAKING CHANGE) #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From discussion offline: This seems reasonable, but as you mentioned it's a lot of code to support a change in configuration format that's not too difficult for people to migrate. |
rfratto
added a commit
to rfratto/agent
that referenced
this pull request
Jan 26, 2021
prerequisite for grafana#353
rfratto
force-pushed
the
multiple-promtail
branch
from
January 27, 2021 17:26
92e383f
to
0d3248a
Compare
rfratto
changed the title
pkg/loki: support multiple instances of promtail
pkg/loki: support multiple instances of promtail (BREAKING CHANGE)
Jan 27, 2021
56quarters
reviewed
Jan 28, 2021
mattdurham
approved these changes
Jan 29, 2021
3 tasks
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
) * pkg/loki: support multiple instances of promtail * fix build, lint errors * docs, fix configs * hard break * changelog * create positions directory if it doesn't exist * fix bugs from testing * remove test extra loki config * update remaining docs to use new loki config * add more detail to the migration guide, config reference * fix loki port
github-actions
bot
added
the
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
label
Apr 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Enables running multiple instances of Promtail in the same way one can run multiple instances of Prometheus. This is a breaking change. Configs in this form:
must be rewritten to be in this new form:
Which issue(s) this PR fixes
Closes #313.
Notes to the Reviewer
Lots to do still. Opening this up in draft to get early feedback based on the versioning approach.
TODO:
agent-all-in-one.yaml
tocmd/agent
for local testing.0700
permissions.PR Checklist