Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on rules for scraping pods #358

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Add note on rules for scraping pods #358

merged 1 commit into from
Jan 26, 2021

Conversation

eamonryan
Copy link
Member

@eamonryan eamonryan commented Jan 26, 2021

Added clarifying rules from #316 (comment) for the default script config to scrape pods.

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

Added clarifying rules from #316 (comment) for the default script config to scrape pods.
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this!

@eamonryan eamonryan merged commit 2d42f42 into master Jan 26, 2021
@eamonryan eamonryan deleted the eamonryan-patch-1 branch January 26, 2021 20:50
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
Added clarifying rules from #316 (comment) for the default script config to scrape pods.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants