Only keep certain K8s API server metrics by default #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating changelog |
rfratto
reviewed
Feb 4, 2021
CHANGELOG.md
Outdated
Comment on lines
7
to
9
| - [ENHANCEMENT] Only keep a handful of K8s API server metrics by default to reduce | ||
| default active series usage. | ||
|
|
There was a problem hiding this comment.
I try to sort the changelog, can you add it after the last [ENHANCEMENT] entry and also credit yourself like the other examples?
Merge branch 'limit_apiserver_metrics' of github.com:grafana/agent into limit_apiserver_metrics
rfratto
approved these changes
Feb 4, 2021
This was referenced Feb 4, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Per #352 and other user feedback, the default scrape configuration results in a large number of metrics being shipped out of the box, which can create a significant storage costs.
Using guidelines from https://grafana.com/docs/grafana-cloud/billing-and-usage/prometheus/usage-reduction-k8s/, this temporary fix only scrapes a handful of API server metrics by default instead of scraping everything (~20k active series).
The inclusion criteria is basically "are these API server metrics referenced in a kubernetes-mixin dashboard." If they are referenced in a recording rule, they are not included here.
This is not a perfect solution to this problem, but a temporary patch to make the default less jarring and cost-intensive for users getting started with the agent.
Which issue(s) this PR fixes
Notes to the Reviewer
@rfratto Please generate the relevant JSON from the Tanka... got a new laptop and still have to set up all the build stuff...Sorry!!
PR Checklist