Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow relying on the default value of the -addr flag in config-sync #396

Merged
merged 2 commits into from
Feb 8, 2021
Merged

allow relying on the default value of the -addr flag in config-sync #396

merged 2 commits into from
Feb 8, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Feb 8, 2021 •
edited
Loading

PR Description

Which issue(s) this PR fixes

Closes #395

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

jdbaldry
jdbaldry approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rfratto rfratto merged commit e115da2 into grafana:master Feb 8, 2021
@rfratto rfratto deleted the allow-default-flag branch February 22, 2021 15:39
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
Closed
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@rfratto
allow relying on the default value of the -addr flag in config-sync (#…
706c922 
…396)

* allow relying on the default value of the -addr flag in config-sync

Closes #395

* changelog
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdbaldry jdbaldry jdbaldry approved these changes

@mattdurham mattdurham Awaiting requested review from mattdurham

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: required flag(s) "addr" not set even though --addr has a configured default value
2 participants
@rfratto @jdbaldry