Allow specifying wal truncate frequencies per integration #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
wal-truncate-in-integrations
branch
from
c28cb65
to
f661144
Compare
rfratto
commented
Feb 17, 2021
| @@ -206,7 +206,7 @@ func (m *Manager) runIntegration(ctx context.Context, cfg Config, i Integration) | |||
| // Apply the config so an instance is launched to scrape our integration. | |||
| instanceConfig := m.instanceConfigForIntegration(cfg, i) | |||
| if err := m.im.ApplyConfig(instanceConfig); err != nil { | |||
| level.Error(m.logger).Log("msg", "failed to apply integration. integration will not run. THIS IS A BUG!", "err", err, "integration", cfg.Name()) | |||
| level.Error(m.logger).Log("msg", "failed to apply integration. integration will not run", "err", err, "integration", cfg.Name()) | |||
There was a problem hiding this comment.
This isn't a bug :) If you provide an invalid scrape interval or bad WAL truncation frequency you can run into this.
mattdurham
approved these changes
Feb 17, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* allow specifying wal truncate frequencies per integration * rebase and fix default time in docs
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds
wal_truncate_frequencyas a common integration setting, allowing to override the forced default.Which issue(s) this PR fixes
Closes #390
Notes to the Reviewer
Blocked by #401.
PR Checklist