Use loki in k3d agent DS instead of promtail #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
commented
Feb 10, 2021
| external_labels: {}, | ||
| }], | ||
|
|
||
| pipeline_stages: [ |
There was a problem hiding this comment.
This block was moved to loki_config.libsonnet.
rfratto
commented
Feb 10, 2021
| @@ -4,4 +4,5 @@ k3d create \ | |||
| --name agent-k3d \ | |||
| --publish 30080:30080 \ | |||
| --api-port 50443 \ | |||
| -v /var/lib/k3d/agent-k3d/storage/:/var/lib/rancher/k3s/storage/ | |||
| -v /var/lib/k3d/agent-k3d/storage/:/var/lib/rancher/k3s/storage/ \ | |||
| -v /etc/machine-id:/etc/machine-id | |||
There was a problem hiding this comment.
This is needed for the Loki to work, where /etc/machine-id is bind-mounted. Promtail didn't need it unless you were reading from the systemd journal, but the Agent config always adds it.
mattdurham
approved these changes
Feb 10, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Removes promtail from the k3d example and replaces it with using a
lokiblock in the Agent DS config.I also found an issue where the positions_directory wasn't set in the production loki config, so it would've broken with 0.12.0.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist