Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer sigv4 region from environment #412

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Feb 17, 2021

PR Description

Allows for inferring the sigv4 region from environment variables or the shared config file. The region specified in the Agent YAML serves as the final override.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had to google aws.String but makes sense with what they are doing.

@rfratto rfratto merged commit c18cde2 into grafana:main Feb 18, 2021
@rfratto rfratto deleted the sigv4-infer-region branch February 18, 2021 14:42
@rfratto rfratto mentioned this pull request Feb 18, 2021
3 tasks
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* infer sigv4 region from environment

* document test

* aws.StringValue
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants