Scraping service: stop scraping service instances on partial shutdown #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the config reloading, but is already handled today: when the overall Agent stop, it stops all intances, including ones retrieved via the scraping service. However, if _just_ the scraping service was stopped, then its instances would continue running in the background. This fixes that problem.
rfratto
changed the title
56quarters
approved these changes
Feb 18, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
…#417) * stop scraping service instances on shutdown This is needed for the config reloading, but is already handled today: when the overall Agent stop, it stops all intances, including ones retrieved via the scraping service. However, if _just_ the scraping service was stopped, then its instances would continue running in the background. This fixes that problem. * log error when failing to delete config on sharding instance manager shutdown * s/error/err for consistency
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is needed for the config reloading, but is already handled today: when the overall Agent stop, it stops all intances, including ones retrieved via the scraping service. However, if just the scraping service was stopped, then its instances would continue running in the background. This fixes that problem.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist