Stop unnecessary config duplication #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_config_duplication
rfratto
reviewed
Feb 25, 2021
mattdurham
changed the title
…nfig_duplication # Conflicts: # CHANGELOG.md # pkg/prom/agent.go
rfratto
approved these changes
Mar 1, 2021
mattdurham
added a commit
that referenced
this pull request
Nov 11, 2021
* Changes to allow config to follow hierarchy * Follow config hierCarchy * Align yaml * Remove unnecessary check for nil * Fix for arguments in tests. * Clean up based on feedback and fixed lint issue. * Go fmt * Documentation updated and changelog * fmt of Yaml * Make defaultRemoteWrite name consistent * Make defaultRemoteWrite name consistent
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This adds a top level
remote writeblock to prometheus that is used as a default to all subsequent blocks. If any of the subsequent blocks are defined then nothing happens. This ensures that it is backward compatible and allows the child to override the parent.Tested under normal usage and also in scraping service mode with hot reloading the configuration.
Which issue(s) this PR fixes
Closes #378
Notes to the Reviewer
Tested under both the normal modes of operation and scraping service.
PR Checklist