allow 0 as a valid truncation timestamp #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A remote_write timestamp of 0 preventing truncations from occurring. Ignoring 0s was an unnecessary safety measure, and only caused problems when considering the min/max WAL sample lifetime. Closes grafana#409.
rfratto
commented
Mar 1, 2021
| continue | ||
| ts := i.getRemoteWriteTimestamp() - i.cfg.MinWALTime.Milliseconds() | ||
| if ts < 0 { | ||
| ts = 0 | ||
| } |
There was a problem hiding this comment.
0 is a perfectly valid timestamp and there was no reason to do this 🤷
mattdurham
approved these changes
Mar 1, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
A remote_write timestamp of 0 preventing truncations from occurring. Ignoring 0s was an unnecessary safety measure, and only caused problems when considering the min/max WAL sample lifetime. Closes #409.
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
A remote_write timestamp of 0 preventing truncations from occurring. Ignoring 0s was an unnecessary safety measure, and only caused problems when considering the min/max WAL sample lifetime.
Which issue(s) this PR fixes
Closes #409.
Notes to the Reviewer
PR Checklist