change the default application semantics of instance configs #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit reduces the number of places defaults are applied to instance configs: 1. When the Agent YAML is unmarshaled 2. When the instance config is loaded from the KV store
mattdurham
approved these changes
Mar 2, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
this commit reduces the number of places defaults are applied to instance configs: 1. When the Agent YAML is unmarshaled 2. When the instance config is loaded from the KV store
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR commit reduces the number of places defaults are applied to instance configs to just:
This makes it easier to follow the lifetime of an instance config.
Which issue(s) this PR fixes
Done in relation to #147.
Notes to the Reviewer
PR Checklist
Internal change, nothing here needed.