pkg/prom/cluster: add config watcher #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
clustering-watcher
branch
from
71e53d1
to
60d830e
Compare
mattdurham
approved these changes
Mar 16, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* initial commit * add tests * address review feedback
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
configWatcheris an internal component that watches a ConfigStore and applies config as they get changed. It also has a polling mechanism to do a full sync against the state of the config store. This is the other half of the existing functionality ofpkg/prom/haand pairs with the work from #461.Which issue(s) this PR fixes
Notes to the Reviewer
Still doing #147 🙃
PR Checklist