Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race condition in pkg/prom/cluster/node_test.go #463

Merged
merged 1 commit into from
Mar 11, 2021
Merged

fix race condition in pkg/prom/cluster/node_test.go #463

merged 1 commit into from
Mar 11, 2021

Commits on Mar 11, 2021

  1. fix race condition in pkg/prom/cluster/node_test.go 

    gRPC service can't be registered after calling Serve on the gRPC server.
Since Serve was being called in a separate goroutine, it was a race
condition for whether it would fail.
    @rfratto
    rfratto committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    97453ad View commit details
    Browse the repository at this point in the history