Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump otel collector version to v0.21.0 #469

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Bump otel collector version to v0.21.0 #469

merged 2 commits into from
Mar 17, 2021

Conversation

mapno
Copy link
Member

@mapno mapno commented Mar 16, 2021 •
edited
Loading

PR Description

Bump otel collector to v0.21.0 to include fix for retry errors.

Which issue(s) this PR fixes

Closes #405
Closes #429

Notes to the Reviewer

Retry is now moved to the exporter. The OTLP exporter used in the agent implements the retry mechanism.

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mapno
Copy link
Member Author

mapno commented Mar 16, 2021

I think there is nothing config-related to change really. Let me know if I missed something.

@rfratto
Copy link
Member

rfratto commented Mar 16, 2021

Thanks!

I think there is nothing config-related to change really. Let me know if I missed something.

I think you might have to update the URLs throughout the docs and pkg/tempo to v0.21.0, especially if the queued processor settings are define somewhere else now.

@mapno
Copy link
Member Author

mapno commented Mar 16, 2021

Oh, right. Updated, thanks!

joe-elliott
joe-elliott approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the work was already done to map the retry settings to the exporters instead of the retry processor?

rfratto
rfratto approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It looks like the work was already done to map the retry settings to the exporters instead of the retry processor?

Yeah, someone did that but I can't remember who at the moment. Might've been @mdisibio?

@mapno mapno force-pushed the opentelemetry-version-bump branch from c7c9c25 to c8754fe Compare March 17, 2021 09:53
@rfratto rfratto merged commit 050299a into grafana:main Mar 17, 2021
@mapno mapno deleted the opentelemetry-version-bump branch September 6, 2021 14:47
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
Closed
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@mapno
Bump otel collector version to v0.21.0 (#469)
fcf1143
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto approved these changes

@joe-elliott joe-elliott joe-elliott approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update go.opentelemetry.io/collector to v0.21.0 Tracing: Grafana Agent retries errors it should not
4 participants
@mapno @CLAassistant @rfratto @joe-elliott