Glue together the new cluster package #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
commented
Mar 16, 2021
| @@ -137,37 +140,6 @@ func (n *node) ApplyConfig(cfg Config) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // WaitJoined waits for the node the join the cluster and enter the | |||
There was a problem hiding this comment.
I moved this function down towards the end of the file so everything here was in usage-order.
mattdurham
approved these changes
Mar 16, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Glues together the new cluster package.
Which issue(s) this PR fixes
Notes to the Reviewer
Notably no integration tests here. I think enough of the logic is covered to fall back on the smoke tests, which I'll do in the next PR when I replace the old package with the new one.
PR Checklist