switch to new cluster package #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. integrations manager should apply changes to config 2. configstore needs a special label to not collide with clustering label 3. add logging to track config watcher better
|
Ready for review, everything looks good. |
mattdurham
approved these changes
Mar 17, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* switch to new cluster package * fix issues from testing 1. integrations manager should apply changes to config 2. configstore needs a special label to not collide with clustering label 3. add logging to track config watcher better * k3d: sync configs between cluster and non-cluster agents * fix nil check in pkg/prom/cluster.node.Stop
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Remove the old
pkg/prom/hapackage and switch to the new cluster package.Which issue(s) this PR fixes
Notes to the Reviewer
Keeping in draft until I do some manual testing against this to verify everything is covered.
PR Checklist