Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka traces receiver #489

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Add kafka traces receiver #489

merged 2 commits into from
Mar 29, 2021

Conversation

mapno
Copy link
Member

@mapno mapno commented Mar 25, 2021

PR Description

Adds the kafka receiver

Which issue(s) this PR fixes

Closes #484

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@mapno mapno changed the title Add kafka traces receiver WIP Add kafka traces receiver Mar 25, 2021
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Before I merge, can you update the changelog?

@joe-elliott Typically we add all the receivers to the install manifest (rendered as YAML here), but since the Kafka receiver works so differently, I don't think we can do the same thing here. WDYT?

@joe-elliott
Copy link
Member

Yeah, agree, it doesn't belong in the install manifest. Is there a place that makes sense to document this new option?

@rfratto
Copy link
Member

rfratto commented Mar 25, 2021

Our docs here are really weak. IMO for now let's just have a list in the docs for tempo_instance_config, something like:

# Receiver configurations are mapped directly into the OpenTelmetry receivers block.
#   At least one receiver is required. Supported receivers: otlp, jaeger, kafka, [...]
#   Documentation for each receiver can be found at https://github.com/open-telemetry/opentelemetry-collector/blob/7d7ae2eb34b5d387627875c498d7f43619f37ee3/receiver/README.md
receivers:

@mapno
Copy link
Member Author

mapno commented Mar 29, 2021

Added the documentation and manually tested the receiver by modifying the docker-compose example. I didn't think it was worth modifying the code. Let me know if you want me to test it some other way (e.g. integration tests).

@mapno mapno changed the title WIP Add kafka traces receiver Add kafka traces receiver Mar 29, 2021
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I'll merge once the conflicts are resolved.

@mapno
Copy link
Member Author

mapno commented Mar 29, 2021

Thanks again! I'll merge once the conflicts are resolved.

They should be solved now

@rfratto rfratto merged commit 8ce3bb5 into grafana:main Mar 29, 2021
@mapno mapno deleted the kafka-trace-receiver branch September 6, 2021 14:47
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for Kafka receiver as mentioned in the documentation
3 participants