Implement Applyconfig for Entrypoint #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
approved these changes
Mar 25, 2021
pkg/integrations/manager.go
Outdated
| scrapeIntegration = *common.ScrapeIntegration | ||
| } | ||
| if scrapeIntegration { | ||
| willCreateInstance = true |
There was a problem hiding this comment.
Could you return early here instead of using the willCreateInstance?
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* implement applyconfig for entrypoint * require WAL when scraping service is enabled * s/NewEntryPoint/NewEntrypoint * address review feedback
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implements ApplyConfig for entrypoint.
This required making a few changes to drastically simplify the implementation: all subsystems are now always enabled. This adds very little resource overhead, but makes the logs a little noisier. Prometheus will now only fail to validate if the WAL isn't configured when at least one instance, integration, or the scraping service is configured.
Which issue(s) this PR fixes
Related to #147.
Notes to the Reviewer
This doesn't change the logger to reflect a change in logging level. I'll follow up with a second PR for that.
PR Checklist