-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Installer Script - Implementation #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
changed the title
Checking in modified version of the installer
Windows Installer Script - Implementation
Mar 29, 2021
Fix type
rfratto
reviewed
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This is really exciting!
rfratto
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Few grammar nits in the docs, but I'm ready for this to be merged.
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
mattdurham
added a commit
that referenced
this pull request
Nov 11, 2021
* Checking in modified version of the installer * Fix tab issue in make * Support Versioning * Add Version to installer output * Add docs for windows installer * Do not overwrite agent-config.yaml if it exists * Use appdata folder instead of program files * Allow reinstlal * Stop service on reinstall before copying files * Remove appdata wal * Fix documentation * Update windows.md Fix type * Changes based on PR * Add license information to the install * Simplify silent install * Update CHANGELOG.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update docs/windows.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update docs/windows.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update docs/windows.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Links to and from documentation * Fix type * Clean up grammar * Clean up grammar Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
label
Apr 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Create windows installer that supports both silent install and guided mode. This installer should automatically be added to the releases list.
Features:
Which issue(s) this PR fixes
Closes #301
Notes to the Reviewer
PR Checklist