Windows Installer Script - Implementation #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
changed the title
Fix type
rfratto
approved these changes
Mar 31, 2021
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
mattdurham
added a commit
that referenced
this pull request
Nov 11, 2021
* Checking in modified version of the installer * Fix tab issue in make * Support Versioning * Add Version to installer output * Add docs for windows installer * Do not overwrite agent-config.yaml if it exists * Use appdata folder instead of program files * Allow reinstlal * Stop service on reinstall before copying files * Remove appdata wal * Fix documentation * Update windows.md Fix type * Changes based on PR * Add license information to the install * Simplify silent install * Update CHANGELOG.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update docs/windows.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update docs/windows.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Update docs/windows.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * Links to and from documentation * Fix type * Clean up grammar * Clean up grammar Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Create windows installer that supports both silent install and guided mode. This installer should automatically be added to the releases list.
Features:
Which issue(s) this PR fixes
Closes #301
Notes to the Reviewer
PR Checklist