Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close WALs after calculating cardinality/sample stats #507

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 1, 2021

PR Description

Closes WALs after agentctl finishes doing analysis.

Which issue(s) this PR fixes

Fixes #506

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@rfratto rfratto requested a review from mattdurham April 1, 2021 12:31
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rfratto rfratto merged commit ffc8236 into grafana:main Apr 1, 2021
@rfratto rfratto deleted the agentctl-leak branch April 1, 2021 14:32
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* close WALs after calculating cardinality/sample stats

* changelog
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/agentctl: FindCardinality, FindSamples do not invoke WAL.Close() hence leaks resources
2 participants