Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installer to output #522

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Add installer to output #522

merged 3 commits into from
Apr 8, 2021

Conversation

mattdurham
Copy link
Collaborator

@mattdurham mattdurham commented Apr 8, 2021

PR Description

Add installer to dist-agent which rolled up to dist

Which issue(s) this PR fixes

Closes #521

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • [NA] Documentation added
  • [NA] Tests updated

@mattdurham mattdurham marked this pull request as ready for review April 8, 2021 13:56
@mattdurham mattdurham requested a review from rfratto April 8, 2021 14:10
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think we should probably add a section in the CHANGELOG for the release candidate which we can then squash when we do the stable release.

CHANGELOG.md Outdated
@@ -55,6 +55,8 @@ and is expected to change will be tagged interchangably as "experimental" or

- [BUGFIX] agentctl will no longer leak WAL resources when retrieving WAL stats. (@rfratto)

- [BUGFIX] Include Windows Installer when building for release (@mattdurham)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move everything in main to a header for 0.14.0-rc.0 and add this to a new master/unerged section?

@mattdurham mattdurham merged commit dcc0f03 into grafana:main Apr 8, 2021
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham added a commit that referenced this pull request Nov 11, 2021
* Add installer to output

* Ad changelog entry

* Update changelog
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Installer not included in release assets
2 participants