-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows doc #530
Windows doc #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please inline the individual collector configs :)
docs/configuration-reference.md
Outdated
The `windows_exporter_config` block configures the `windows_exporter` | ||
integration, which is an embedded version of | ||
[`windows_exporter`](https://github.com/grafana/windows_exporter). This allows | ||
for the collection of windows metrics and exposing them as Prometheus metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the collection of windows metrics and exposing them as Prometheus metrics. | |
for the collection of Windows metrics and exposing them as Prometheus metrics. |
docs/configuration-reference.md
Outdated
# Configuration for Exchange Mail Server | ||
[exchange: <exchange_config>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to make new sections for each of these, you can inline them:
exchange:
# Comma-separated List of collectors to use. Defaults to all, if not specified.
# Maps to collectors.exchange.enabled in windows_exporter
[enabled_list: <string>]
* Add windows configuration documentation * Flush out comments and fix misspelled name * Fix space * Fix minor spacing/spelling issues * Inline configuration
PR Description
Add the lost and forgotten windows_exporter configuration documentation
Which issue(s) this PR fixes
Relates to #475
Notes to the Reviewer
PR Checklist