Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows doc #530

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Windows doc #530

merged 5 commits into from
Apr 9, 2021

Conversation

mattdurham
Copy link
Collaborator

PR Description

Add the lost and forgotten windows_exporter configuration documentation

Which issue(s) this PR fixes

Relates to #475

Notes to the Reviewer

PR Checklist

  • [NA] CHANGELOG updated
  • Documentation added
  • [NA] Tests updated

@mattdurham mattdurham requested a review from rfratto April 9, 2021 13:50
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please inline the individual collector configs :)

The `windows_exporter_config` block configures the `windows_exporter`
integration, which is an embedded version of
[`windows_exporter`](https://github.com/grafana/windows_exporter). This allows
for the collection of windows metrics and exposing them as Prometheus metrics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for the collection of windows metrics and exposing them as Prometheus metrics.
for the collection of Windows metrics and exposing them as Prometheus metrics.

Comment on lines 3535 to 3536
# Configuration for Exchange Mail Server
[exchange: <exchange_config>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to make new sections for each of these, you can inline them:

exchange: 
  # Comma-separated List of collectors to use. Defaults to all, if not specified.
  # Maps to collectors.exchange.enabled in windows_exporter
  [enabled_list: <string>]

@mattdurham mattdurham merged commit 1ee4e68 into main Apr 9, 2021
@mattdurham mattdurham deleted the windows_doc branch April 9, 2021 14:22
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham added a commit that referenced this pull request Nov 11, 2021
* Add windows configuration documentation

* Flush out comments and fix misspelled name

* Fix space

* Fix minor spacing/spelling issues

* Inline configuration
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants