Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempo: Use correct logger in Prom SD #539

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Tempo: Use correct logger in Prom SD #539

merged 1 commit into from
Apr 14, 2021

Conversation

joe-elliott
Copy link
Member

PR Description

Noticed this while working on other changes. I believe we were using the wrong logger in our SD processor.

@joe-elliott
pass correct logger
2feba97 
Signed-off-by: Joe Elliott <number101010@gmail.com>
rfratto
rfratto approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ideally we wouldn't use a logger based off of util.Logger (line 39), but it should be mostly equivalent and I know how hard it is to propagate custom objects through the OTel constructors. Merge at will!

@joe-elliott joe-elliott merged commit d030b38 into grafana:main Apr 14, 2021
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
Closed
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@joe-elliott
pass correct logger (#539)
29a71c9 
Signed-off-by: Joe Elliott <number101010@gmail.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-elliott @rfratto