Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add harcoded namespace to spanmetrics #540

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Add harcoded namespace to spanmetrics #540

merged 3 commits into from
Apr 16, 2021

Conversation

mapno
Copy link
Member

@mapno mapno commented Apr 14, 2021

PR Description

Add a hardcoded namespace to "brand" the metrics as tempo metrics. Metrics can still be further namespace'd.

Which issue(s) this PR fixes

This comment: https://github.com/grafana/deployment_tools/pull/9416#discussion_r612409931

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

rfratto
rfratto approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my part 👍 can we update the config reference to note that the default namespace will be tempo_spanmetrics?

@mapno
Copy link
Member Author

mapno commented Apr 14, 2021

Looks good on my part 👍 can we update the config reference to note that the default namespace will be tempo_spanmetrics?

Yea, good idea. Added in 0326661.

@mapno mapno merged commit bc099ee into grafana:main Apr 16, 2021
@mapno mapno deleted the spanmetrics-namespace branch April 16, 2021 09:52
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
Closed
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
@mapno
Add harcoded namespace to spanmetrics (#540)
6b70747 
* Add harcoded namespace to spanmetrics

* Update changelog

* Specify namespace default in docs
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mapno @rfratto