clustering: fix handling of empty join-addresses flag #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
thampiotr
reviewed
Oct 12, 2023
|
|
||
| func TestBuildClusterService(t *testing.T) { | ||
| opts := clusterOptions{ | ||
| JoinPeers: []string{"foo", "bar"}, |
There was a problem hiding this comment.
Shouldn't we have a test with JoinPeers empty string somewhere, or setting a flag to it?
There was a problem hiding this comment.
Yes, looking into it.
There was a problem hiding this comment.
(sorry, didn't post the comment beforehand).
After taking a look we don't have a good place for putting tests related to flag parsing. I'd like to (sooner or later) move ahead with #4973 which would cover this. I'm merging this to move ahead with the patch release.
thampiotr
approved these changes
Oct 12, 2023
|
Hi, I am the one who reported this defect #108849 grafana-agent-flow clustering mode error. Seems you guys have fixed it. Thanks. |
|
You're welcome @juyongli! Let us know how clustering works for you and any other feedback you may have! |
tpaschalis
added a commit
to tpaschalis/agent
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com> (cherry picked from commit 0a5a5aa)
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
We recently almost had this bite us when porting the cadvisor integration to a new component.
strings.Splitreturns the input string itself if the separator is not found; this meant that for an empty flag,strings.Split("", ",")returned a 1-element slice with the empty string, and not an empty slice.Which issue(s) this PR fixes
Fixes #5449
Notes to the Reviewer
Nothing to note.
PR Checklist