Apply defaults to undefined sections #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
added a commit
to rfratto/agent
that referenced
this pull request
Apr 22, 2021
PR grafana#546 introduced a default value for the overall Config struct which overwrote the defaults coming from flags. This commit ensures that flag-level defaults take precedence.
rfratto
added a commit
to rfratto/agent
that referenced
this pull request
Apr 22, 2021
PR grafana#546 introduced a default value for the overall Config struct which overwrote the defaults coming from flags. This commit ensures that flag-level defaults take precedence.
3 tasks
rfratto
added a commit
that referenced
this pull request
Apr 22, 2021
PR #546 introduced a default value for the overall Config struct which overwrote the defaults coming from flags. This commit ensures that flag-level defaults take precedence.
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
PR #546 introduced a default value for the overall Config struct which overwrote the defaults coming from flags. This commit ensures that flag-level defaults take precedence.
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
#545 found that defining just an
integrationsblock prevented integrations from being scraped. This was found to be because the default scrape_interval and scrape_timeout weren't being applied whenprometheuswasn't present in the config file.This change ensures that defaults are applied appropriately to empty files (or files without a given section). Only defaults for integrations and prometheus need to be defined, as integrations depends on prometheus (and no other subsystem has defaults).
Which issue(s) this PR fixes
Fixes #545
Notes to the Reviewer
PR Checklist