Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade packages in dockerfile #5463

Merged
merged 2 commits into from
Oct 12, 2023
Merged

upgrade packages in dockerfile #5463

merged 2 commits into from
Oct 12, 2023

Conversation

captncraig
Copy link
Contributor

@captncraig captncraig commented Oct 12, 2023

This resolves a number of (afaik unexploitable) cves.

Mantic does not have definitions yet, but there are updated libc6 packages. This runs apt-get upgrade -y in the dockerfile.

@captncraig captncraig requested a review from a team as a code owner October 12, 2023 16:25
@captncraig captncraig changed the title update to ubuntu:mantic upgrade packages in dockerfile Oct 12, 2023
@ptodev
Copy link
Contributor

ptodev commented Oct 12, 2023

My only concern with this is that it could update the packages to different versions every time, making the build less reproducible. If we can update just the one package to the version we need, maybe it'd be better.

@captncraig
Copy link
Contributor Author

That's a valid point, but not as long as we are building off plain ubuntu:lunar which also receives periodic updates. And these CVE reports come in at random intervals too. I'd be open to solving the problem, but I'd rather close these cve issues first.

@captncraig captncraig merged commit 1c370a0 into main Oct 12, 2023
9 checks passed
@captncraig captncraig deleted the cmp_mantic branch October 12, 2023 21:45
tpaschalis pushed a commit to tpaschalis/agent that referenced this pull request Oct 16, 2023
* update to ubuntu:mantic

* back to lunar, but with upgrade

(cherry picked from commit 1c370a0)
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants