-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tempo] Automatic Logging #551
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9cfe6d9
garbage POC, let's goooooooooooOOO!
joe-elliott aed6b14
Added basic configuration
joe-elliott 09d2464
Added skeleton processor
joe-elliott 6ee0a46
first pass config wiring
joe-elliott d161788
got things to work?
joe-elliott 71482e5
kinda sorta works
joe-elliott ebc8aa7
made things work
joe-elliott 1c88fdc
fixed-ish dur. upped loki and grafana
joe-elliott 4dc4805
fixed duration, added svc name, did processes correctly
joe-elliott 0082076
Added tempo
joe-elliott 3ad6059
configurable tags
joe-elliott bdda148
config
joe-elliott 74b72a2
Addd stopping flag
joe-elliott f6463d9
Added tests
joe-elliott 7d3dc64
Added configurable stuff
joe-elliott c974804
Added automatic logging to docs
joe-elliott e0238ea
added otel config test
joe-elliott 7e018c3
Made tid configurable
joe-elliott e967715
changelog
joe-elliott df7002e
Merge branch 'main' into loki-exporter
joe-elliott 2395de8
Removed zero valued defaults
joe-elliott 55d8f4e
Put changelog entry in the proper spot
joe-elliott c210739
- _processor
joe-elliott 7b6761c
fixed tests
joe-elliott a8338d5
Added cross config validation
joe-elliott 0370820
review suggestions
joe-elliott 71c8fd5
First pass SendEntry
joe-elliott a0d6503
lint
joe-elliott f345a73
Added configurable timeout
joe-elliott dbcefc8
Addd logging message when bad things happen
joe-elliott 93c3033
Actually check sent :P
joe-elliott c70d070
review cleanup
joe-elliott 8633639
config updates
joe-elliott a05e17c
duh
joe-elliott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: what enables this? Is it defining
automatic_logging
in the config or is it providing a value forloki_name
? Can we document which?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
automatic_logging
will instantiate the processor, but it will fail with an error message if it can't find the providedloki_name
.