Scraping service: harden security restrictions on instance files #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
approved these changes
Apr 23, 2021
56quarters
reviewed
Apr 23, 2021
rfratto
changed the title
simonswine
reviewed
Apr 23, 2021
| return nil | ||
| } | ||
|
|
||
| func validateDiscoveryNoFiles(disc discovery.Config) error { |
There was a problem hiding this comment.
I would consider using reflection, to avoid breakage when new discovery mechanisms are added
mattdurham
approved these changes
Apr 26, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* add security warning for scraping service API * implement dangerous_allow_reading_files for scraping service * add breaking changes to migration guide * tests
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.