-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scraping service: harden security restrictions on instance files #558
Scraping service: harden security restrictions on instance files #558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, I like this approach a lot more than just adding the warning in the docs. I'd love to see tests for this but this approach is 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
return nil | ||
} | ||
|
||
func validateDiscoveryNoFiles(disc discovery.Config) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider using reflection, to avoid breakage when new discovery mechanisms are added
* add security warning for scraping service API * implement dangerous_allow_reading_files for scraping service * add breaking changes to migration guide * tests
No description provided.