Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent Windows Uninstaller #577

Merged
merged 8 commits into from
May 3, 2021
Merged

Conversation

mattdurham
Copy link
Collaborator

@mattdurham mattdurham commented May 3, 2021

PR Description

Add silent uninstall to Grafana Agent on Windows and change the install directory to default 64 bit.

Which issue(s) this PR fixes

Closes #564
Closes #576

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@mattdurham mattdurham changed the title Uninstall windows Silent Windows Uninstaller May 3, 2021
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nits!

CHANGELOG.md Outdated Show resolved Hide resolved
packaging/windows/install_script.nsis Show resolved Hide resolved
@mattdurham mattdurham marked this pull request as ready for review May 3, 2021 15:42
@mattdurham mattdurham merged commit 9038739 into grafana:main May 3, 2021
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham added a commit that referenced this pull request Nov 11, 2021
* Change default directory to Program Files and add silent uninstall.

* Update changelog.

* Update directory for defaults in doc.

* Change ordering of "changes"
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
2 participants