Add missing network options to node_exporter doc #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rfratto
approved these changes
May 26, 2021
|
@rfratto I think you need to approve the CI run |
|
@AndreZiviani Ah, thanks, I'm still not used to how that works now. I approved the run. |
|
@rfratto something broke in windows test, since my change is only on a doc maybe a rerun can fix? |
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
node_exporter integration doc is missing some parameters that enable the agent to monitor the node network instead of just the pod's
hostPID: trueis in the upstream node_exporter dochostNetwork: trueso we have access to node network (doc)dnsPolicy: ClusterFirstWithHostNetso we can still resolve cluster dns names (doc)Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist