Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote write exporter not pushing span metrics #624

Merged
merged 2 commits into from
May 28, 2021

Conversation

mapno
Copy link
Member

@mapno mapno commented May 28, 2021

PR Description

Append ts in milliseconds as expected, instead of nanoseconds

Which issue(s) this PR fixes

Fixes #617

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@mapno mapno requested a review from joe-elliott as a code owner May 28, 2021 10:41
@mapno mapno merged commit 9b39197 into grafana:main May 28, 2021
@mapno mapno deleted the remote-write-exporter-timestamp-fix branch May 28, 2021 12:58
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* Ts in milliseconds instead of nanoseconds

* Changelog
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanmetrics doesn't seem to be pushing metrics
2 participants