Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include agent-operator as a release asset #637

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jun 9, 2021

PR Description

Adds agent-operator as a release asset. This only includes it as a Docker image, since it doesn't make much sense (IMO, at least for now) for it to also be a plain binary, given its intention to run on Kubernetes.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@rfratto rfratto requested a review from mattdurham June 9, 2021 14:00
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but LGTM

Grafana Agent is currently distributed in plain binary form, Docker
container images, and a Kubernetes install script. Choose whichever fits your
use-case best.
Grafana Agent is currently distributed in plain binary form, Docker container images, and a Kubernetes install script. Choose whichever fits your use-case best.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the windows installer?

@rfratto rfratto merged commit 4af620a into grafana:main Jun 9, 2021
@rfratto rfratto deleted the build-operator branch June 9, 2021 15:03
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* build agent-operator as a release asset

* mention Windows installer in release-note template
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants