-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs for the Grafana Agent Operator #651
Conversation
serviceAccountName: grafana-agent-operator | ||
containers: | ||
- name: operator | ||
image: grafana/agent-operator:v0.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This image doesn't exist yet, if you're going to test this out locally you'll need to make agent-operator-image
, re-tag it, and apply it to the k3d cluster using k3d image import -c agent-operator grafana/agent-operator:v0.15.0
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just left some minor comments
|
||
Two labels are added by default to every metric: | ||
|
||
- `cluster`, representing the `GrafanaAgent` deployment. Holds the value of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this override the cluster label from k8s SD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, k8s SD doesn't actually have a cluster label, but it's a common pattern to manually add one
Co-authored-by: Mario <mariorvinas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* docs for the Grafana Agent Operator * fix identation of nested lists * Update docs/operator/README.md Co-authored-by: Mario <mariorvinas@gmail.com> * more detail in README * describe why CRDs * mirror docs/operator/README.md intro to cmd/agent-operator/README.md Co-authored-by: Mario <mariorvinas@gmail.com>
Adds docs for the Grafana Agent Operator introduced in #549.