Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudwatch exporter dependency #6835

Open
wants to merge 59 commits into
base: main
Choose a base branch
from

Conversation

andriikushch
Copy link
Contributor

@andriikushch andriikushch commented Apr 9, 2024

PR Description

This PR adds a new configuration parameter for the Cloudwatch exporter. It allows the specification of the AWS SDK version to be used. v1 is the default version.

It was achieved by updating and integrating the version of the github.com/nerdswords/yet-another-cloudwatch-exporter package and all dependencies that it depends on.

According to the https://github.com/nerdswords/yet-another-cloudwatch-exporter/blob/a275f94e5d33b3b5330ecfced86c290e1db05928/pkg/config/feature_flags.go#L10 , using the AWS SDK v2, should improve performance.

Breaking change

After this change, using aliases for the AWS service names is no longer allowed.

Which issue(s) this PR fixes

N.A.

A related change in the Alloy project:

Notes to the Reviewer

There is a breaking change in the PR.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@andriikushch
Copy link
Contributor Author

@rfratto rfratto added variant/static Related to Grafana Agent Static. variant/flow Relatd to Grafana Agent Flow. outdated-dependency Depdency of the project that is out of date labels Apr 9, 2024
@andriikushch andriikushch marked this pull request as ready for review May 10, 2024 13:10
@andriikushch andriikushch marked this pull request as draft May 10, 2024 13:59
andriikushch and others added 6 commits May 14, 2024 13:53
…udwatch.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
…ter-dependency

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	internal/build/build.go
@andriikushch andriikushch marked this pull request as ready for review May 16, 2024 16:34
@andriikushch andriikushch marked this pull request as draft May 16, 2024 16:35
@clayton-cornell clayton-cornell requested a review from a team May 16, 2024 22:16
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 16, 2024
@andriikushch andriikushch marked this pull request as ready for review May 21, 2024 08:52
@clayton-cornell
Copy link
Contributor

Doc changes look OK to me. Over to the @grafana/grafana-agent-maintainers for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated-dependency Depdency of the project that is out of date type/docs Docs Squad label across all Grafana Labs repos variant/flow Relatd to Grafana Agent Flow. variant/static Related to Grafana Agent Static.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants